Repository navigation
[19.0][MIG] web_sheet_full_width: Migration to 19.0 - #3618
idris-domatix wants to merge 26 commits into
Conversation
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
- Add margin for better visibility - Add web_sheet_full_width migration state Done - Update to new OCA README.rst format.
[MIG] adapt web_sheet_full_width to V10.0 web framework
…renthesis in readme.
| .o_FormRenderer_chatterContainer { | ||
| // 19.0: la clase o_FormRenderer_chatterContainer ya no existe. El chatter | ||
| // dentro de un formulario pasa a o-mail-Form-chatter (nomenclatura o-mail-* | ||
| // introducida al reescribir Discuss en OWL). |
BhaveshHeliconia
left a comment
There was a problem hiding this comment.
I tested it locally and on runboat, but the functionality is not working.
6c36ed1 to
950c7f7
Compare
|
Thanks for the review. @BhaveshHeliconia the module was not working because, since v17, the sheet Fixed by targeting
Also translated the SCSS and manifest comments to English, as requested. |
BhaveshHeliconia
left a comment
There was a problem hiding this comment.
Functional review LGTM!
|
This PR has the |
dreispt
left a comment
There was a problem hiding this comment.
I'm sorry, the module commit history is missing!
We should have the history until 18.0 and then the 19.0 migration specific commits as per migration wiki instructions.
|
@idris-domatix Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0. |
* less -> scss * fragment readme + add a pointer to web_responsive
More specifically, in web_enterprise the selector .o_form_view.o_xxl_form_view > .o_form_sheet_bg > .o_form_sheet fixes the width and has more specificity than this one
950c7f7 to
6b8b3d1
Compare
|
Thanks @dreispt and @BhaveshHeliconia. I had squashed the whole module into a single commit, which was wrong. I have restored the module commit history and rebased to fixup only the administrative commits into the contributor commit that generated them:
Note: in OCA/web this module was only present up to 16.0 (there is no 17.0/18.0 branch for |
|
This PR has the |
6b8b3d1 to
0ab8dc7
Compare
|
Thanks @dreispt, good catch. The glitch appears when Fixed by also resetting Verified locally reproducing the Runboat setup (CRM opportunity form,
The commit history is preserved; the change is part of the |
CristianoMafraJunior
left a comment
There was a problem hiding this comment.
Commit naming: fix from [19.0][MIG] web_sheet_full_width: Migration to 19.0 to [MIG] web_sheet_full_width: Migration to 19.0
|
Will fix the commit subject to |
|
Gentle nudge on this one when there's a window. @dreispt |
0ab8dc7 to
395fcdd
Compare
|
Thanks for the review. The migration commit subject has been updated to |
| <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> | ||
| <meta name="generator" content="Docutils: https://docutils.sourceforge.io/" /> | ||
| <title>Web Sheet Full Width</title> | ||
| <title>README.rst</title> |
There was a problem hiding this comment.
The title is reverting to the old default
lucaorioli
left a comment
There was a problem hiding this comment.
Functional test on a 19.0 instance, also together with web_chatter_resizable (#3775): the two modules work well together.
Up to 2600px wide the sheet now uses the whole width: forms without chatter, forms with the chatter below, and forms where the side chatter is hidden.
On a wider screen the form still stops at 2600px: core also limits .o_form_renderer ($o-form-renderer-max-width, web/static/src/views/form/form_controller.scss), which contains the sheet. This rule removes it, tested locally:
.o_form_view {
.o_form_renderer {
max-width: none;
}
}Would you add it, so the module is "full width" on wide screens too?

Migration of
web_sheet_full_widthto 19.0Standard migration. Module history ported from 16.0.
Migration changes:
versionbumped to19.0.1.0.0, and assets moved from the removedweb.assets_commonbundle toweb.assets_backend(the common bundle was split in 19.0)..o_FormRenderer_chatterContainer→.o-mail-Form-chatter(renamed in 19.0).<?xml ?>declaration fromstatic/description/index.html(in 19.0 it breaksdescription_htmlcomputation and prevents the module from installing).pyproject.toml(whool).Validation (local, without demo, mirroring CI):
pre-commitgreen.--test-enable --without-demo=all: clean, module loads without traceback.No Python tests in this module.